xintongsong commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-819175527
Thanks for preparing this PR, @galenwarren. I'll try to take a look asap. Quick response to your questions. - The licensing issues are described [here](https://cwiki.apache.org/confluence/display/FLINK/Licensing). In short, you need to manually create the NOTICE file. The script is mainly used for generating the root NOTICE file from those of the sub-modules. - I think `commit` should fail if the file is already committed. The contract of this interface says it publishes the file, making it visible. We should not allow a job restarted from an earlier checkpoint/savepoint to overwrite a published file. BTW, AZP failed during compiling. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
