[jira] [Commented] (FLINK-21839) SinkFunction snapshotState don't snapshot all data when trigger a stop-with-drain savepoint

[Dawid Wysakowicz (Jira)]

    [ 
https://issues.apache.org/jira/browse/FLINK-21839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320858#comment-17320858
 ] 

Dawid Wysakowicz commented on FLINK-21839:
------------------------------------------

I merged the minor clarification to docs:
* master
** 81118c0d6c24b6b9883f3e1285964458030a24fc
* 1.12.3
** 682b255ed7a0acbf91877b9b37889bf1e757da19

> SinkFunction snapshotState don't snapshot all data when trigger a 
> stop-with-drain savepoint
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-21839
>                 URL: https://issues.apache.org/jira/browse/FLINK-21839
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Checkpointing
>    Affects Versions: 1.12.2
>            Reporter: Darcy Lin
>            Assignee: Yuan Mei
>            Priority: Critical
>         Attachments: TestSink.java
>
>
> This problem was discovered when I was developing the flink code. In my flink 
> code, my custom sink don't send all data that be produced by event_time 
> window when trigger stop-with-drain savepoint .
> TestSink.java is a example that SinkFunction invoke() continues to run after 
> snapshotState() executed when trigger a stop-with-drain savepoint by rest api.
> {code:java}
> //TaskSink.java log
> sink open
> invoke: 0
> invoke: 1
> invoke: 2
> invoke: 3
> invoke: 4
> invoke: 5
> invoke: 6
> invoke: 7
> invoke: 8
> invoke: 9
> ...
> invoke: 425
> invoke: 426
> invoke: 427
> snapshotState
> invoke: 428 // It should be executed before snapshotState.
> sink close{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)