[ 
https://issues.apache.org/jira/browse/FLINK-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251900#comment-15251900
 ] 

Vasia Kalavri commented on FLINK-3772:
--------------------------------------

Hi [~greghogan],
I see your point about performance. But judging from your pull request, this 
adds a new set of utilities for Gelly.

So far, Gelly has had 3 components: 
- graph transformations (basically methods of the Graph class)
- iteration abstractions (vertex-centric, gsa, and scatter-gather)
- library of algorithms (which one can simply call with {{graph.run()}}).

Your PR adds a caching utility and a set of degree annotation functions. I am 
personally in favor and always excited about additions and extensions to Gelly. 
However, as the codebase is growing, several people have often raised the point 
that we need to be careful about adding new functionality. This, together with 
FLINK-3771, are considerably big additions and I think it would be best to see 
what the community thinks first. Would you mind starting a discussion in the 
dev mailing list about these issues?

Thank you!

> Graph algorithms for vertex and edge degree
> -------------------------------------------
>
>                 Key: FLINK-3772
>                 URL: https://issues.apache.org/jira/browse/FLINK-3772
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.1.0
>
>
> Many graph algorithms require vertices or edges to be marked with the degree. 
> This ticket provides algorithms for annotating
> * vertex degree for undirected graphs
> * vertex out-, in-, and out- and in-degree for directed graphs
> * edge source, target, and source and target degree for undirected graphs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to