[ 
https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252249#comment-15252249
 ] 

ASF GitHub Bot commented on FLINK-3650:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1856#discussion_r60620452
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMinFunction.java
 ---
    @@ -48,7 +49,7 @@ public SelectByMinFunction(TupleTypeInfo<T> type, int... 
fields) {
                        }
     
                        // Check whether type is comparable
    -                   if (!type.getTypeAt(field).isKeyType()) {
    +                   if 
(!((TupleTypeInfo)type).getTypeAt(field).isKeyType()) {
    --- End diff --
    
    Scala tuple types are not of type `TupleTypeInfo` but instead 
`TupleTypeInfoBase`.


> Add maxBy/minBy to Scala DataSet API
> ------------------------------------
>
>                 Key: FLINK-3650
>                 URL: https://issues.apache.org/jira/browse/FLINK-3650
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: ramkrishna.s.vasudevan
>
> The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}. 
> These methods are not supported by the Scala DataSet API. These methods 
> should be added in order to have a consistent API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to