[
https://issues.apache.org/jira/browse/FLINK-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254535#comment-15254535
]
ASF GitHub Bot commented on FLINK-2946:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-213565509
Thanks for opening this PR @dawidwys!
I skimmed over the changes and it looks good. I will do a more detailed
review hopefully soon.
Thanks also for adding a lot of tests. It is definitely good to have
extensive test coverage, but end-to-end tests such as yours add quite a bit to
the build time. Flink uses Travis as CI service which kills builds after 2h.
Unfortunately, we are experiencing build time outs already and have to be
careful when adding tests.
I would like to ask you to remove some of the tests which check for
different expression syntax but end up in identical executions. In addition, it
would be good to add one SQL test that executes a query which sorts on two
fields to have the SQL part covered.
We will add a unit test framework, that checks for correct parsing of the
expressions without actually executing queries in a separate effort.
> Add orderBy() to Table API
> --------------------------
>
> Key: FLINK-2946
> URL: https://issues.apache.org/jira/browse/FLINK-2946
> Project: Flink
> Issue Type: New Feature
> Components: Table API
> Reporter: Timo Walther
> Assignee: Dawid Wysakowicz
>
> In order to implement a FLINK-2099 prototype that uses the Table APIs code
> generation facilities, the Table API needs a sorting feature.
> I would implement it the next days. Ideas how to implement such a sorting
> feature are very welcome. Is there any more efficient way instead of
> {{.sortPartition(...).setParallism(1)}}? Is it better to sort locally on the
> nodes first and finally sort on one node afterwards?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
