[
https://issues.apache.org/jira/browse/FLINK-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17323392#comment-17323392
]
Flink Jira Bot commented on FLINK-11372:
----------------------------------------
This issue is assigned but has not received an update in 7 days so it has been
labeled "stale-assigned". If you are still working on the issue, please give an
update and remove the label. If you are no longer working on the issue, please
unassign so someone else may work on it. In 7 days the issue will be
automatically unassigned.
> Incorrect delegation of compatibility checks to new snapshots in
> CollectionSerializerConfigSnapshot
> ---------------------------------------------------------------------------------------------------
>
> Key: FLINK-11372
> URL: https://issues.apache.org/jira/browse/FLINK-11372
> Project: Flink
> Issue Type: Bug
> Components: API / Type Serialization System
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Major
> Labels: pull-request-available, stale-assigned
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In {{CollectionSerializerConfigSnapshot}}:
> {code}
> @Override
> public TypeSerializerSchemaCompatibility<C>
> resolveSchemaCompatibility(TypeSerializer<C> newSerializer) {
> if (newSerializer instanceof ListSerializer) {
> ListSerializer<T> newListSerializer = (ListSerializer<T>)
> newSerializer;
> ListSerializerSnapshot<T> listSerializerSnapshot = new
> ListSerializerSnapshot<>(newListSerializer);
> @SuppressWarnings("unchecked")
> TypeSerializerSchemaCompatibility<C> result =
> (TypeSerializerSchemaCompatibility<C>)
>
> listSerializerSnapshot.resolveSchemaCompatibility(newListSerializer);
> return result;
> } else {
> return super.resolveSchemaCompatibility(newSerializer);
> }
> }
> {code}
> Compatibility check of {{ListSerializer}} is delegated to the new list
> serializer snapshot class, {{ListSerializerSnapshot}}.
> However, it is incorrect to let the delegate wrap the new serializer (and
> therefore the new nested element serializer). By doing that, we're
> essentially checking compatibility of the new serializer with itself, whereas
> it should be checking compatibility with the restored serializer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
