[
https://issues.apache.org/jira/browse/FLINK-21844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17323765#comment-17323765
]
Nicholas Jiang edited comment on FLINK-21844 at 4/16/21, 12:42 PM:
-------------------------------------------------------------------
[~trohrmann], [~chesnay], do you mean that the restore from savepoint shoud be
before the ExecutionGraph creation? Now, loading the savepoint and validating
the ExecutionJobVertex is after the creation of ExecutionGraph. IMO, this could
remove the validation of max parallelism, because the max parallelism
restriction of savepoint obstructs the max parallelism of ExecutionJobVertex
determine.
was (Author: nicholasjiang):
[~trohrmann], [~chesnay], do you mean that the restore from savepoint shoud be
before the ExecutionGraph creation?
Now, loading the savepoint and validating the ExecutionJobVertex is after the
creation of ExecutionGraph.
> Do not auto-configure maxParallelism when setting "scheduler-mode: reactive"
> ----------------------------------------------------------------------------
>
> Key: FLINK-21844
> URL: https://issues.apache.org/jira/browse/FLINK-21844
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
> Reporter: Konstantin Knauf
> Assignee: Austin Cawley-Edwards
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> I believe we should not automatically change the maxParallelism when the
> "scheduler-mode" is set to "reactive", because:
> * it magically breaks savepoint compatibility, when you switch between
> default and reactive scheduler mode
> * the maximum parallelism is an orthogonal concern that in my opinion should
> not be mixed with the scheduler mode. The reactive scheduler should respect
> the maxParallelism, but it should not set/ change its default value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
