XComp commented on a change in pull request #15640:
URL: https://github.com/apache/flink/pull/15640#discussion_r615737641
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/exceptionhistory/FailureHandlingResultSnapshotTest.java
##########
@@ -115,7 +156,12 @@ public void
testLocalFailureHandlingResultSnapshotCreation() {
FailureHandlingResultSnapshot.create(
failureHandlingResult, this::getExecutionVertex);
- assertThat(testInstance.getRootCause(), is(rootCause));
+ // SerializableThrowable needs to be wrapped around to expose the
deserializeError method -
+ // the check would fail, otherwise.
+ assertThat(
+ new SerializedThrowable(testInstance.getRootCause())
+ .deserializeError(ClassLoader.getSystemClassLoader()),
+ is(rootCause));
Review comment:
Good catch. I did some code changes afterwards that made the wrapping
obsolete. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
