rkhachatryan commented on a change in pull request #15674:
URL: https://github.com/apache/flink/pull/15674#discussion_r615894456



##########
File path: 
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunction.java
##########
@@ -178,6 +178,7 @@ public JdbcXaSinkFunction(
                 new XaSinkStateHandlerImpl(),
                 options,
                 new XaGroupOpsImpl(xaFacade));
+        Preconditions.checkArgument(executionOptions.getMaxRetries() == 0, 
"JDBC XA sink requires maxRetries = 0");        

Review comment:
       I've noticed checkstyle 
[failed](https://github.com/apache/flink/pull/15674#issuecomment-822428583) 
here:
   ```
   2021-04-19T12:56:46.7896738Z [ERROR] 
src/main/java/org/apache/flink/connector/jdbc/xa/JdbcXaSinkFunction.java:[181] 
(regexp) RegexpSingleline: Trailing whitespace
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to