godfreyhe commented on a change in pull request #14484:
URL: https://github.com/apache/flink/pull/14484#discussion_r616333752
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/multipleinput/MultipleInputStreamOperatorBase.java
##########
@@ -245,9 +245,9 @@ private void
createAllOperators(StreamOperatorParameters<RowData> parameters) {
output = outputs[0];
} else {
if (isObjectReuseEnabled) {
Review comment:
please add some comments for this behavior, just like the comments in
OperatorChain#createOutputCollector method
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorITCase.java
##########
@@ -67,6 +67,43 @@ public static void setup() {
hiveCatalog.getHiveConf(),
HiveShimLoader.getHiveVersion());
}
+ @Test
+ public void testMultiInputBroadcast() throws Exception {
+ TableEnvironment tableEnv = getTableEnvWithHiveCatalog();
+ tableEnv.executeSql("create database db1");
+ try {
+ tableEnv.useDatabase("db1");
+ tableEnv.executeSql("create table src1(key string, val string)");
+ tableEnv.executeSql("create table src2(key string, val string)");
+ tableEnv.executeSql("create table dest(key string, val string)");
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "src1")
+ .addRow(new Object[] {"1", "val1"})
+ .addRow(new Object[] {"2", "val2"})
+ .addRow(new Object[] {"3", "val3"})
+ .commit();
+ HiveTestUtils.createTextTableInserter(hiveCatalog, "db1", "src2")
+ .addRow(new Object[] {"3", "val4"})
+ .addRow(new Object[] {"4", "val4"})
+ .commit();
+ tableEnv.executeSql(
+ "INSERT OVERWRITE dest\n"
+ + "SELECT j.*\n"
+ + "FROM (SELECT t1.key, p1.val\n"
+ + " FROM src2 t1\n"
+ + " LEFT OUTER JOIN src1 p1\n"
+ + " ON (t1.key = p1.key)\n"
+ + " UNION ALL\n"
+ + " SELECT t2.key, p2.val\n"
+ + " FROM src2 t2\n"
+ + " LEFT OUTER JOIN src1 p2\n"
+ + " ON (t2.key = p2.key)) j")
+ .await();
Review comment:
do we need to check the result ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
