Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1929#issuecomment-214664097
One additional remark. I'd like to get rid of these fields in
`FileSplitMonitoringFunctionTest`:
```
private Set<org.apache.hadoop.fs.Path> hdPaths = new HashSet<>();
private Set<String> hdPathNames = new HashSet<>();
private Map<Integer, String> hdPathContents = new HashMap<>();
```
and replace them by local variables in the tests. Like it is now the
interactions of the different methods are hard to follow. Also, in the
`FileSplitMonitoringITCase` the fields are there but not read.
Also, we should replace the `@Before` and `@After` hooks by `@BeforeClass`
and `@AfterClass` hooks because the creation/deletion of the HDFS cluster is
very expensive and we do it once per test right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
