[
https://issues.apache.org/jira/browse/FLINK-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257726#comment-15257726
]
ASF GitHub Bot commented on FLINK-3803:
---------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1927#issuecomment-214665070
Test failures are unrelated and I have two successful runs in my local
Travis: https://travis-ci.org/uce/flink/builds/125561984,
https://travis-ci.org/uce/flink/builds/125563304.
I'm going to merge this for 1.1.0 and 1.0.3.
> Checkpoint Stats Tracker Reads from Wrong Configuration
> -------------------------------------------------------
>
> Key: FLINK-3803
> URL: https://issues.apache.org/jira/browse/FLINK-3803
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.0.0
> Reporter: Aljoscha Krettek
> Assignee: Ufuk Celebi
>
> In {{ExecutionGraph.java}} when configuring the checkpoint stats tracker the
> config values are read from the {{jobConfiguration}}:
> {code}
> boolean isStatsDisabled = jobConfiguration.getBoolean(
> ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_DISABLE,
> ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_DISABLE);
> if (isStatsDisabled) {
> checkpointStatsTracker = new DisabledCheckpointStatsTracker();
> }
> else {
> int historySize = jobConfiguration.getInteger(
> ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE,
> ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE);
> checkpointStatsTracker = new SimpleCheckpointStatsTracker(historySize,
> tasksToWaitFor);
> }
> {code}
> The settings are only available in the Flink Configuration, however. Right
> now, the {{ExecutionGraph}} has no access to the Flink Configuration.
> I see three solutions:
> - pass the Flink Configuration to the {{ExecutionGraph}}
> - pass just the two required settings to the {{ExecutionGraph}}
> - Introduce a new {{ExecutionGraphSettings}} that contains settings only for
> the {{ExecutionGraph}} in order to clean up things a bit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
