pnowojski commented on a change in pull request #15714:
URL: https://github.com/apache/flink/pull/15714#discussion_r617748629
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -475,8 +475,10 @@ public void onBuffer(Buffer buffer, int sequenceNumber,
int backlog) throws IOEx
DataType dataType = buffer.getDataType();
if (dataType.hasPriority()) {
firstPriorityEvent = addPriorityBuffer(sequenceBuffer);
+ recycleBuffer = false;
Review comment:
I was thinking about this, but such change would require an assumption
that:
```
if (dataType.requiresAnnouncement()) {
firstPriorityEvent = addPriorityBuffer(announce(sequenceBuffer));
}
```
Doesn't throw any exception ever. Which I think is not strictly speaking
true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
