[
https://issues.apache.org/jira/browse/FLINK-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257920#comment-15257920
]
ASF GitHub Bot commented on FLINK-3809:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1935
[FLINK-3809/FLINK-3810] Add missing breaks in
ZKLeader(Election/Retrieval)Services
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3809_3810
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1935.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1935
----
commit 51f7e52e961977a5483debdcdc2d013effa395b4
Author: zentol <[email protected]>
Date: 2016-04-26T11:20:46Z
[FLINK-3810] Add missing breaks in ZKElectionService
commit 9c2a39eb4dcfc2ae744a81a8b41138544e15b805
Author: zentol <[email protected]>
Date: 2016-04-26T11:21:03Z
[FLINK-3809] Add missing breaks in ZKRetrievalService
----
> Missing break in ZooKeeperLeaderRetrievalService#handleStateChange()
> --------------------------------------------------------------------
>
> Key: FLINK-3809
> URL: https://issues.apache.org/jira/browse/FLINK-3809
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chesnay Schepler
>
> {code}
> protected void handleStateChange(ConnectionState newState) {
> switch (newState) {
> case CONNECTED:
> LOG.debug("Connected to ZooKeeper quorum. Leader retrieval can
> start.");
> case SUSPENDED:
> LOG.warn("Connection to ZooKeeper suspended. Can no longer retrieve
> the leader from " +
> "ZooKeeper.");
> case RECONNECTED:
> LOG.info("Connection to ZooKeeper was reconnected. Leader retrieval
> can be restarted.");
> case LOST:
> LOG.warn("Connection to ZooKeeper lost. Can no longer retrieve the
> leader from " +
> "ZooKeeper.");
> }
> {code}
> Except for LOST state, the other states would lead to multiple logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
