wuchong commented on a change in pull request #15630: URL: https://github.com/apache/flink/pull/15630#discussion_r618123663
########## File path: docs/content/docs/connectors/table/hive/hive_dialect.md ########## @@ -346,33 +344,33 @@ CREATE FUNCTION function_name AS class_name; DROP FUNCTION [IF EXISTS] function_name; ``` -## DML - -### INSERT +## DML & DQL _`Beta`_ -```sql -INSERT (INTO|OVERWRITE) [TABLE] table_name [PARTITION partition_spec] SELECT ...; -``` +Hive dialect supports a commonly-used subset of Hive's [DML](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML) +and [DQL](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Select). The following lists some examples of +HiveQL supported by the Hive dialect. -The `partition_spec`, if present, can be either a full spec or partial spec. If the `partition_spec` is a partial -spec, the dynamic partition column names can be omitted. +- [SORT/CLUSTER/DISTRIBUTE BY](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+SortBy) +- [Grouping Sets and GROUPING__ID function](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+GroupBy#LanguageManualGroupBy-GroupingSets,Cubes,Rollups,andtheGROUPING__IDFunction) +- [INSERT INTO dest schema](https://issues.apache.org/jira/browse/HIVE-9481) +- [LATERAL VIEW](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+LateralView) +- [Implicit type conversions](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-AllowedImplicitConversions) Review comment: Are all the supported syntax are listed above? e.g. Select, Join, Union, Subqueries, Lateral views, Over, CTE. https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Select#LanguageManualSelect-MoreSelectSyntax ########## File path: docs/content/docs/connectors/table/hive/hive_dialect.md ########## @@ -346,33 +344,33 @@ CREATE FUNCTION function_name AS class_name; DROP FUNCTION [IF EXISTS] function_name; ``` -## DML - -### INSERT +## DML & DQL _`Beta`_ -```sql -INSERT (INTO|OVERWRITE) [TABLE] table_name [PARTITION partition_spec] SELECT ...; -``` +Hive dialect supports a commonly-used subset of Hive's [DML](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DML) +and [DQL](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Select). The following lists some examples of +HiveQL supported by the Hive dialect. -The `partition_spec`, if present, can be either a full spec or partial spec. If the `partition_spec` is a partial -spec, the dynamic partition column names can be omitted. +- [SORT/CLUSTER/DISTRIBUTE BY](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+SortBy) +- [Grouping Sets and GROUPING__ID function](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+GroupBy#LanguageManualGroupBy-GroupingSets,Cubes,Rollups,andtheGROUPING__IDFunction) +- [INSERT INTO dest schema](https://issues.apache.org/jira/browse/HIVE-9481) +- [LATERAL VIEW](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+LateralView) +- [Implicit type conversions](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-AllowedImplicitConversions) -## DQL +In order to have better syntax and semantic compatibility, it's highly recommended to use [HiveModule]({{< ref "docs/connectors/table/hive/hive_functions" >}}#use-hive-built-in-functions-via-hivemodule) +and place it first in the module list, so that Hive built-in functions can be picked up during function resolution. -At the moment, Hive dialect supports the same syntax as Flink SQL for DQLs. Refer to -[Flink SQL queries]({{< ref "docs/dev/table/sql/queries" >}}) for more details. And it's recommended to switch to -`default` dialect to execute DQLs. +Hive dialect no longer supports [Flink SQL queries]({{< ref "docs/dev/table/sql/queries" >}}). Please switch to `default` +dialect if you'd like to write in Flink syntax. Review comment: Could you add some examples to show how to setup a hive dialect environement? Including setting dialects, setting modules ordering, and some quries/DMLs/HiveUDFs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
