Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1900#issuecomment-214733082
Hi @greghogan,
I looked at the PR in more detail and I have some thoughts.
First, why do we need a `Translate` class and `Translator` interface? Can't
we simply add methods in the `Graph` class that wrap a `MapFunction` or receive
it as an argument like in `mapVertices`?
Second, translating values is already supported by `mapVertices` and
`mapEdges`. Couldn't we simply extend these methods to also support changing
the vertex key types?
Let me know what you think! Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
