[
https://issues.apache.org/jira/browse/FLINK-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260112#comment-15260112
]
Fabian Hueske commented on FLINK-2971:
--------------------------------------
Hi Dawid,
I think the approach is good. A few comments on the WIP branch:
- I'd call the {{onColumns}} parameter rather {{joinPredicate}} to indicate
that a predicate (boolean expression) is expected.
- Does Calcite accept non join predicates or do we have to check for that?
- Is the partial function actually a partial function if the last case catches
everything?
- I think we can rename {{UnresolvedFieldReference}} to {{FieldReference}} and
remove {{ResolvedFieldReference}} which is not used anymore. Hence
{{MultiInputUnresolvedFieldReference}} can also be shorter.
Thanks, for working on this!
> Add outer joins to the Table API
> --------------------------------
>
> Key: FLINK-2971
> URL: https://issues.apache.org/jira/browse/FLINK-2971
> Project: Flink
> Issue Type: New Feature
> Components: Table API
> Reporter: Timo Walther
> Assignee: Dawid Wysakowicz
>
> Since Flink now supports outer joins, the Table API can also support left,
> right and full outer joins.
> Given that null values are properly supported by RowSerializer etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
