Github user yjshen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1916#discussion_r61378731
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/test/ScalarFunctionsTest.scala
 ---
    @@ -215,7 +215,7 @@ class ScalarFunctionsTest {
     
       }
     
    -  @Test
    +  @Ignore
    --- End diff --
    
    `exp` `log` `pow` and `ln` should have `Double` as input. What I was 
thinking is, we should add some extra `type coercion` rules and add an `cast` 
when we can do it safely(when an expression is asking a `Double` but we provide 
a `Int`), for example, `Byte` to `Double`, `Long` to `Double` and so on, and 
rewrite the expression as `pow(cast(x, Double))`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to