[
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262090#comment-15262090
]
ASF GitHub Bot commented on FLINK-3754:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1916#issuecomment-215414605
If we decide for eager validation, we can also simplify the code a bit,
right?
I might be wrong but we could remove `PlanPreparation` and the recursive
validation of `LogicalNode` since the inputs of an operator would have been
already validated. The checks of `Validator.validate()` could be moved to the
respective `LogicalNode`. Not sure if we would still need the `RuleExecutor`.
> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
> Key: FLINK-3754
> URL: https://issues.apache.org/jira/browse/FLINK-3754
> Project: Flink
> Issue Type: Improvement
> Components: Table API
> Affects Versions: 1.0.0
> Reporter: Yijie Shen
> Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before
> RelNode construction, Table API lacks the counterparts and the validation is
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as
> possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
