[ 
https://issues.apache.org/jira/browse/FLINK-22266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329943#comment-17329943
 ] 

Guowei Ma edited comment on FLINK-22266 at 4/23/21, 3:02 AM:
-------------------------------------------------------------

I found that the case still failed on the master branch
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=17077&view=logs&j=8fd9202e-fd17-5b26-353c-ac1ff76c8f28&t=a0a633b8-47ef-5c5a-2806-3c13b9e48228&l=3885

{code:java}
Apr 22 21:44:59 [ERROR] 
testRestartCheckpointCoordinatorIfStopWithSavepointFails(org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase)
  Time elapsed: 60.366 s  <<< FAILURE!
Apr 22 21:44:59 java.lang.AssertionError
Apr 22 21:44:59         at org.junit.Assert.fail(Assert.java:86)
Apr 22 21:44:59         at org.junit.Assert.assertTrue(Assert.java:41)
Apr 22 21:44:59         at org.junit.Assert.assertTrue(Assert.java:52)
Apr 22 21:44:59         at 
org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase.testRestartCheckpointCoordinatorIfStopWithSavepointFails(JobMasterStopWithSavepointITCase.java:244)
Apr 22 21:44:59         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
Apr 22 21:44:59         at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Apr 22 21:44:59         at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Apr 22 21:44:59         at java.lang.reflect.Method.invoke(Method.java:498)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
Apr 22 21:44:59         at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
Apr 22 21:44:59         at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
Apr 22 21:44:59         at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 22 21:44:59         at 
org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
Apr 22 21:44:59         at 
org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
Apr 22 21:44:59         at org.junit.rules.RunRules.evaluate(RunRules.java:20)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)


{code}



{code:java}

Apr 22 21:44:59 [ERROR] 
testRestartCheckpointCoordinatorIfStopWithSavepointFails(org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase)
  Time elapsed: 60.366 s  <<< ERROR!
Apr 22 21:44:59 java.lang.IllegalStateException: MiniCluster is not yet running 
or has already been shut down.
Apr 22 21:44:59         at 
org.apache.flink.util.Preconditions.checkState(Preconditions.java:193)
Apr 22 21:44:59         at 
org.apache.flink.runtime.minicluster.MiniCluster.getDispatcherGatewayFuture(MiniCluster.java:850)
Apr 22 21:44:59         at 
org.apache.flink.runtime.minicluster.MiniCluster.runDispatcherCommand(MiniCluster.java:750)
Apr 22 21:44:59         at 
org.apache.flink.runtime.minicluster.MiniCluster.listJobs(MiniCluster.java:683)
Apr 22 21:44:59         at 
org.apache.flink.client.program.MiniClusterClient.listJobs(MiniClusterClient.java:111)
Apr 22 21:44:59         at 
org.apache.flink.test.util.AbstractTestBase.cleanupRunningJobs(AbstractTestBase.java:73)
Apr 22 21:44:59         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
Apr 22 21:44:59         at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Apr 22 21:44:59         at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Apr 22 21:44:59         at java.lang.reflect.Method.invoke(Method.java:498)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
Apr 22 21:44:59         at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
Apr 22 21:44:59         at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 22 21:44:59         at 
org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
Apr 22 21:44:59         at 
org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
Apr 22 21:44:59         at org.junit.rules.RunRules.evaluate(RunRules.java:20)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr
{code}




was (Author: maguowei):
I found that the case still failed. 
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=17077&view=logs&j=8fd9202e-fd17-5b26-353c-ac1ff76c8f28&t=a0a633b8-47ef-5c5a-2806-3c13b9e48228&l=3885

{code:java}
Apr 22 21:44:59 [ERROR] 
testRestartCheckpointCoordinatorIfStopWithSavepointFails(org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase)
  Time elapsed: 60.366 s  <<< FAILURE!
Apr 22 21:44:59 java.lang.AssertionError
Apr 22 21:44:59         at org.junit.Assert.fail(Assert.java:86)
Apr 22 21:44:59         at org.junit.Assert.assertTrue(Assert.java:41)
Apr 22 21:44:59         at org.junit.Assert.assertTrue(Assert.java:52)
Apr 22 21:44:59         at 
org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase.testRestartCheckpointCoordinatorIfStopWithSavepointFails(JobMasterStopWithSavepointITCase.java:244)
Apr 22 21:44:59         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
Apr 22 21:44:59         at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Apr 22 21:44:59         at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Apr 22 21:44:59         at java.lang.reflect.Method.invoke(Method.java:498)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
Apr 22 21:44:59         at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
Apr 22 21:44:59         at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
Apr 22 21:44:59         at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 22 21:44:59         at 
org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
Apr 22 21:44:59         at 
org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
Apr 22 21:44:59         at org.junit.rules.RunRules.evaluate(RunRules.java:20)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)


{code}



{code:java}

Apr 22 21:44:59 [ERROR] 
testRestartCheckpointCoordinatorIfStopWithSavepointFails(org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase)
  Time elapsed: 60.366 s  <<< ERROR!
Apr 22 21:44:59 java.lang.IllegalStateException: MiniCluster is not yet running 
or has already been shut down.
Apr 22 21:44:59         at 
org.apache.flink.util.Preconditions.checkState(Preconditions.java:193)
Apr 22 21:44:59         at 
org.apache.flink.runtime.minicluster.MiniCluster.getDispatcherGatewayFuture(MiniCluster.java:850)
Apr 22 21:44:59         at 
org.apache.flink.runtime.minicluster.MiniCluster.runDispatcherCommand(MiniCluster.java:750)
Apr 22 21:44:59         at 
org.apache.flink.runtime.minicluster.MiniCluster.listJobs(MiniCluster.java:683)
Apr 22 21:44:59         at 
org.apache.flink.client.program.MiniClusterClient.listJobs(MiniClusterClient.java:111)
Apr 22 21:44:59         at 
org.apache.flink.test.util.AbstractTestBase.cleanupRunningJobs(AbstractTestBase.java:73)
Apr 22 21:44:59         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
Apr 22 21:44:59         at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Apr 22 21:44:59         at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Apr 22 21:44:59         at java.lang.reflect.Method.invoke(Method.java:498)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
Apr 22 21:44:59         at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Apr 22 21:44:59         at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
Apr 22 21:44:59         at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 22 21:44:59         at 
org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
Apr 22 21:44:59         at 
org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
Apr 22 21:44:59         at org.junit.rules.RunRules.evaluate(RunRules.java:20)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
Apr 22 21:44:59         at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
Apr 22 21:44:59         at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 22 21:44:59         at 
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr
{code}



> Harden JobMasterStopWithSavepointITCase
> ---------------------------------------
>
>                 Key: FLINK-22266
>                 URL: https://issues.apache.org/jira/browse/FLINK-22266
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Checkpointing, Runtime / Coordination
>    Affects Versions: 1.13.0, 1.14.0
>            Reporter: Guowei Ma
>            Assignee: Dawid Wysakowicz
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.13.0
>
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=16451&view=logs&j=5c8e7682-d68f-54d1-16a2-a09310218a49&t=f508e270-48d6-5f1e-3138-42a17e0714f0&l=3884
> {code:java}
> [ERROR] 
> throwingExceptionOnCallbackWithNoRestartsShouldFailTheTerminate(org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase)
>   Time elapsed: 0.154 s  <<< FAILURE!
> java.lang.AssertionError
>       at org.junit.Assert.fail(Assert.java:86)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at org.junit.Assert.assertTrue(Assert.java:52)
>       at 
> org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase.throwingExceptionOnCallbackWithoutRestartsHelper(JobMasterStopWithSavepointITCase.java:154)
>       at 
> org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase.throwingExceptionOnCallbackWithNoRestartsShouldFailTheTerminate(JobMasterStopWithSavepointITCase.java:138)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>       at 
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
>       at 
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
>       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>       at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to