yittg commented on a change in pull request #15501:
URL: https://github.com/apache/flink/pull/15501#discussion_r619038524
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/FlinkKubeClient.java
##########
@@ -184,6 +174,15 @@ KubernetesWatch watchConfigMaps(
*/
CompletableFuture<Void> deleteConfigMap(String configMapName);
+ /**
+ * Create a shared watcher for ConfigMaps with specified labels.
+ *
+ * @param labels labels to filter ConfigMaps, if labels is empty or null,
all ConfigMaps will be
+ * take in account.
Review comment:
It depends on the implementation? We can change the doc like following:
if labels is null or empty, all ConfigMaps will be take in account or
rejected if the implementation does not allow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
