Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1900#discussion_r61550681
  
    --- Diff: 
flink-libraries/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/Graph.scala
 ---
    @@ -407,6 +407,36 @@ TypeInformation : ClassTag](jgraph: jg.Graph[K, VV, 
EV]) {
       }
     
       /**
    +   * Relabels vertices and edges using the given MapFunction.
    +   *
    +   * @param translator implements conversion from K to NEW
    +   * @return relabeled graph
    +   */
    +  def translateGraphLabels[NEW: TypeInformation : ClassTag](translator: 
MapFunction[K, NEW]): Graph[NEW,VV,EV] = {
    --- End diff --
    
    In the the Gelly code and docs, we refer to the vertex and edge keys as 
"Ids", not labels. I think we should rename the methods and javadocs to be 
consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to