zuston commented on pull request #15653:
URL: https://github.com/apache/flink/pull/15653#issuecomment-826453832


   @lirui-apache Thanks for your reply.
   
   > Would it be better to inject the credentials when the configuration is 
firstly created? For example, when we create the JobConf in 
HiveDynamicTableFactory, or when we create HiveConf in HiveCatalog
   
   Good point. I will try~
   
   > Besides, is it possible to add some test to cover this behavior?
   
   Scenarios like kerberos are difficult to cover through unit tests, 
[PR#15131](https://github.com/apache/flink/pull/15131) is the same problem.
   But maybe related code can refer to, such as Spark ([linked 
url](https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala#L203))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to