Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1900#issuecomment-215738750
I pushed the most recent changes. In order of things I care more about to
things I care less about:
The indentation is as intended. I find method chaining on a single line
quite difficult to follow. I find that algorithms are much easier to read if
separate operators are easily identifiable.
Cramming `implements`, `extends`, and `throws` onto a single line is also
difficult to parse, particularly for complicated nested parameters which may
themselves extend interfaces.
There are empty lines throughout the code. The remaining two look fine to
me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
