[
https://issues.apache.org/jira/browse/FLINK-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264127#comment-15264127
]
ASF GitHub Bot commented on FLINK-3771:
---------------------------------------
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1900#issuecomment-215738750
I pushed the most recent changes. In order of things I care more about to
things I care less about:
The indentation is as intended. I find method chaining on a single line
quite difficult to follow. I find that algorithms are much easier to read if
separate operators are easily identifiable.
Cramming `implements`, `extends`, and `throws` onto a single line is also
difficult to parse, particularly for complicated nested parameters which may
themselves extend interfaces.
There are empty lines throughout the code. The remaining two look fine to
me.
> Methods for translating Graphs
> ------------------------------
>
> Key: FLINK-3771
> URL: https://issues.apache.org/jira/browse/FLINK-3771
> Project: Flink
> Issue Type: New Feature
> Components: Gelly
> Affects Versions: 1.1.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Fix For: 1.1.0
>
>
> Provide methods for translation of the type or value of graph labels, vertex
> values, and edge values.
> Sample use cases:
> * shifting graph labels in order to union generated graphs or graphs read
> from multiple sources
> * downsizing labels or values since algorithms prefer to generate wide types
> which may be expensive for further computation
> * changing label type for testing or benchmarking alternative code paths
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
