tillrohrmann commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r620431654
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo
"/usr/local/bin/minikube-$MINIKUBE_VERSION")
Review comment:
Then we could maybe change it so that we use whatever version is
available and if `minikube` is not available, then we try to download minikube
on Linux. On MacOS we fail with a descriptive message. This would be a somewhat
consistent behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
