Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1955#issuecomment-216221749
Thanks for this PR @vasia.
I noticed a few things:
- The docs page (`./apis/table.html`) still has the menu of the DataSet API
on the left hand side. Is it possible to remove it?
- Could you add support of `Table.orderBy()` to the table. We forgot to
update the docs when the feature was added.
- I think we should add a note to the SQL section that it is not feature
complete and only supports what the Table API supports. Hence it does not
support: Outer joins, distinct aggregates, date and decimal data types, and
more .
I have a few more suggestions:
- Overall, the documentation is quite focused on the Table API and how it
integrates with the DataSet and DataStream API. I think it would be good to
describe it as an independent API for relational stream *and* batch processing
with a good integration into the DataSet and DataStream API. Table API and SQL
should be described as equivalent APIs.
- We could move the section about table registration out of the Table API
section. It is also valid for SQL and could go into the "Using the Table API
and SQL" section (or become a top-level section itself). We could also describe
the registration as the default way to create tables and the describe the
`DataSet`/`DataStream` -> `Table` conversions of the Table API as shortcuts.
Might be easier to understand.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
