[ 
https://issues.apache.org/jira/browse/FLINK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266503#comment-15266503
 ] 

ASF GitHub Bot commented on FLINK-2044:
---------------------------------------

Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/1956#issuecomment-216222300
  
    Hi @gallenvara,
    
    thank you for the PR! I only took a quick look, but I will go through the 
changes in detail soon.
    One thing I noticed is that you use static variables for performing the 
normalization. This won't work in a distributed environment. You will need to 
use aggregators instead. Take a look at 
`IterationConfiguration.registerAggregator`. `VertexUpdateFunction` and 
`MessagingFunction` have methods to retrieve an aggregator and an aggregated 
value from the previous superstep. Let me know if you need help :)


> Implementation of Gelly HITS Algorithm
> --------------------------------------
>
>                 Key: FLINK-2044
>                 URL: https://issues.apache.org/jira/browse/FLINK-2044
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>            Reporter: Ahamd Javid
>            Assignee: GaoLun
>            Priority: Minor
>
> Implementation of Hits Algorithm in Gelly API using Java. the feature branch 
> can be found here: (https://github.com/JavidMayar/flink/commits/HITS)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to