Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1953#issuecomment-216251703
Overall, the code looks good. I forgot that we have the avro dependency in
by default ;)
I had one minor commit regarding early input validation, other than that
the change is good to merge.
If there'll be more rolling file sinks are coming, we might need to put
them into dedicated maven modules to avoid a dependency mess for the module.
But avro is an exception here ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
