[
https://issues.apache.org/jira/browse/FLINK-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266693#comment-15266693
]
ASF GitHub Bot commented on FLINK-3854:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1953#issuecomment-216251703
Overall, the code looks good. I forgot that we have the avro dependency in
by default ;)
I had one minor commit regarding early input validation, other than that
the change is good to merge.
If there'll be more rolling file sinks are coming, we might need to put
them into dedicated maven modules to avoid a dependency mess for the module.
But avro is an exception here ;)
> Support Avro key-value rolling sink writer
> ------------------------------------------
>
> Key: FLINK-3854
> URL: https://issues.apache.org/jira/browse/FLINK-3854
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Affects Versions: 1.0.3
> Reporter: Igor Berman
>
> Support rolling sink writer in avro key value format.
> preferably without additional classpath dependencies
> preferable in same format as M/R jobs for backward compatibility
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
