[
https://issues.apache.org/jira/browse/FLINK-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268523#comment-15268523
]
ASF GitHub Bot commented on FLINK-3856:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1959
[FLINK-3856] [core] Create types for java.sql.Date/Time/Timestamp
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This PR adds java.sql.Date/Time/Timestamp as basic types. I declared them
PublicEvolving, therefore I didn't add the types to the documentation. I
improved the Date serialization to use Long.MIN_VALUE instead of -1. But it
still does not solve FLINK-3858 completely.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink DateTimeTimestamp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1959.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1959
----
commit b294fe3f1988582baf4b1d948d95e1efd5293d80
Author: twalthr <[email protected]>
Date: 2016-05-02T14:31:45Z
[FLINK-3856] [core] Create types for java.sql.Date/Time/Timestamp
----
> Create types for java.sql.Date/Time/Timestamp
> ---------------------------------------------
>
> Key: FLINK-3856
> URL: https://issues.apache.org/jira/browse/FLINK-3856
> Project: Flink
> Issue Type: New Feature
> Components: Core
> Reporter: Timo Walther
> Assignee: Timo Walther
>
> At the moment there is only the {{Date}} type which is not sufficient for
> most use cases about time.
> The Table API would also benefit from having different types as output result.
> I would propose to add the three {{java.sql.}} types either as {{BasicTypes}}
> or in an additional class {{TimeTypes}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
