AHeise commented on a change in pull request #15728:
URL: https://github.com/apache/flink/pull/15728#discussion_r621948252
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlanCalculator.java
##########
@@ -111,7 +112,10 @@ public void setAllowCheckpointsAfterTasksFinished(boolean
allowCheckpointsAfterT
? calculateAfterTasksFinished()
: calculateWithAllTasksRunning();
- checkTasksStarted(result.getTasksToTrigger());
+ checkTasksStarted(
+ isUnalignedCheckpoint
+ ? result.getTasksToWaitFor()
+ : result.getTasksToTrigger());
Review comment:
> In this case old behavior (for AC) is combined with the new behaviour
(for UC) and this seems misleading from both users and developers point of view
IMO.
Also a fair point. I don't have a strong opinion on this anymore as I think
both versions are good (and a bit bad). If you say that it's easier for the
user (not 100% clear to me) and dev to unify it, then I'm for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
