[
https://issues.apache.org/jira/browse/FLINK-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335131#comment-17335131
]
Leonard Xu commented on FLINK-17826:
------------------------------------
Hi, [~f.pompermaier]
The concern about the custom query is that
(1) After add a custom query, the JDBC table should be a view of JDBC (e.g
select * from db1.A join db1.B) instead of a table from semantics.
(2) The table may can only be used as source table and can not as sink table
for example above case.
base on these, I tend to do not add the unclear option.
But If you're interesting this issue, you can take over and I can help review
and merge. We can add some specification for (1) and add more checks for (2)
> Add missing custom query support on new jdbc connector
> ------------------------------------------------------
>
> Key: FLINK-17826
> URL: https://issues.apache.org/jira/browse/FLINK-17826
> Project: Flink
> Issue Type: Bug
> Components: Connectors / JDBC
> Reporter: Jark Wu
> Assignee: Leonard Xu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> In FLINK-17361, we added custom query on JDBC tables, but missing to add the
> same ability on new jdbc connector (i.e.
> {{JdbcDynamicTableSourceSinkFactory}}).
> In the new jdbc connector, maybe we should call it {{scan.query}} to keep
> consistent with other scan options, besides we need to make {{"table-name"}}
> optional, but add validation that "table-name" and "scan.query" shouldn't
> both be empty, and "table-name" must not be empty when used as sink.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
