rkhachatryan commented on a change in pull request #15772:
URL: https://github.com/apache/flink/pull/15772#discussion_r622815281



##########
File path: 
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
##########
@@ -264,6 +264,10 @@
             <td>Tolerable Failed Checkpoints</td>
             <td>{{ checkPointConfig['tolerable_failed_checkpoints'] }}</td>
           </tr>
+          <tr>
+            <td>Alignment timeout</td>
+            <td>{{ checkPointConfig['alignment_timeout'] }}</td>
+          </tr>

Review comment:
       I ran a job locally and observed that:
   1. Timeout is shown if UC are disabled (in which case it doesn't make any 
sense). Do you think we should/could hide it? Or maybe show a relevant portion 
from docs (`ExecutionCheckpointingOptions`), for example as a tooltip?
   1. Same if it is zero. 
   1. Timeout is shown as a last line. Could you make it next to "unaligned 
checkpoints"?
   1. Timeout is shown without a unit. Could you add a unit similar to 
checkpoint_timeout?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to