pnowojski commented on a change in pull request #15728:
URL: https://github.com/apache/flink/pull/15728#discussion_r622838956
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlanCalculator.java
##########
@@ -111,7 +112,10 @@ public void setAllowCheckpointsAfterTasksFinished(boolean
allowCheckpointsAfterT
? calculateAfterTasksFinished()
: calculateWithAllTasksRunning();
- checkTasksStarted(result.getTasksToTrigger());
+ checkTasksStarted(
+ isUnalignedCheckpoint
+ ? result.getTasksToWaitFor()
+ : result.getTasksToTrigger());
Review comment:
ok, +1 from my side on unifying the behaviour between UC and AC.
One more question from my side. Is this change compatible with FLIP-147?
When some of the sources have already or are about to `FINISHED`?
`calculateAfterTasksFinished` a couple of lines above suggest so, but can you
double check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
