Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62018169
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/JDBCInputSplitsGenerator.java
---
@@ -15,17 +15,14 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.flink.api.java.io.jdbc;
+package org.apache.flink.api.java.io.jdbc.split;
-import java.io.OutputStream;
+import java.io.Serializable;
-@SuppressWarnings("unused")
-/**
- * Utility class to disable derby logging
- */
-public class DerbyUtil {
- public static final OutputStream DEV_NULL = new OutputStream() {
- public void write(int b) {
- }
- };
+import org.apache.flink.api.java.io.QueryParamInputSplit;
+
+public interface JDBCInputSplitsGenerator extends Serializable {
+
+ /** Returns the necessary parameters array to use for splitting a table
*/
+ public QueryParamInputSplit[] getInputSplits(int minNumSplits);
--- End diff --
I would rather define a method `Object[][] getParameterValues(int
numberOfQueries)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
