akalash commented on a change in pull request #15772:
URL: https://github.com/apache/flink/pull/15772#discussion_r623000410
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
##########
@@ -264,6 +264,10 @@
<td>Tolerable Failed Checkpoints</td>
<td>{{ checkPointConfig['tolerable_failed_checkpoints'] }}</td>
</tr>
+ <tr>
+ <td>Alignment timeout</td>
+ <td>{{ checkPointConfig['alignment_timeout'] }}</td>
+ </tr>
Review comment:
1. I think showing the docs from ExecutionCheckpointingOptions is a good
idea but it's better to do it in siperated ticket. But in this ticket, I agree
that we can hide the timeout if UC is disabled
2. I don't think that we should hide the field if it has value zero(if UC is
enabled) because it is better to see that value is zero than think why you
don't see this field because it is zero or because it isn't supported
3. done
4. done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
