Airblader opened a new pull request #15809:
URL: https://github.com/apache/flink/pull/15809
## What is the purpose of the change
When converting a configuration value to a string, durations were formatted
in nanoseconds regardless of their values. This produces serialized outputs
which are hard to understand for humans.
The functionality of formatting in the highest unit which allows the value
to be an integer already exists, thus we can simply defer to it to produce
a more useful result.
## Brief change log
1. `ConfigurationUtils#convertValue` → `ConfigurationUtils#convertToString`
now defers to `TimeUtils#formatWithHighestUnit` for `Duration`s.
## Verifying this change
This change added tests and can be verified as follows:
1. `TimeUtils#formatWithHighestUnit` is already covered by
`TimeUtilsPrettyPrintingTest`.
2. We've added a new test to `ConfigurationUtils` that covers some basic
scenarios for `convertToString`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
