galenwarren commented on pull request #15599: URL: https://github.com/apache/flink/pull/15599#issuecomment-829308582
@xintongsong I think we've made it through your comments, so far, and I understand how to proceed. For any comment I didn't reply to, I'll just take your suggestion. If there's anything still outstanding from your perspective, please let me know. The one thing we haven't talked about is adding some logging. I agree that would be a good idea. Are there any conventions I should be following here? I didn't see anything specific in the coding guidelines. I'm happy to just take a crack at it, but if there are some guidelines I should be following, just let me know. Enjoy the holiday. I'll try to have something for you the week after next, after the holiday week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
