Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1956#issuecomment-217070480
Thanks a lot, @greghogan @vasia .
My limited understand on the tips your have mentioned :
1) The PR implemented HITS by dividing hub&authority updating into two
phases. Value updating and normalization limit the two phased can not be
handled in the same `superstep`. IMO, we can cache the hub updating result and
send them to next authority iteration and package final authority and hub value
as `Tuple2` type to return. What's your opinion on this?
2) GSA does not support for choosing edge direction and each vertex will be
updated based on the values of its in-neighbors only. In the implementation,
hub updating use the value of target vertex where the edge direction is out,
authority updating used the value of the value of source vertex where the edge
direction is in. IMO, it does not work for hub updating procedure if used GSA.
3)Yes, vertices have been initialized in the test. It should be better to
be set into the algortithm before the first iteration using
`Graph.translateVertexValues`.
4) Because the edge value not used, the translation is optional and it can
keep its original value and type.
5) Yes, adding threshold may reduce iteration time for the case of small
graph with great `maxIteration`. (Does the scatter-gather or GSA have a default
threshold to check for no value updating during the iteration?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
