Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1962#discussion_r62174087
  
    --- Diff: 
flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
 ---
    @@ -177,7 +180,72 @@ public void open(Configuration configuration) {
                if (LOG.isInfoEnabled()) {
                        LOG.info("Created Elasticsearch TransportClient {}", 
client);
                }
    +   }
    +
    +   @Override
    +   public void invoke(final T element) {
    +           ParameterTool params = ParameterTool.fromMap(userConfig);
    +
    +           if (params.has(CONFIG_NO_OF_CONN_RETRIES) && 
params.getInt(CONFIG_NO_OF_CONN_RETRIES) > 0) {
    +                   final Timer timer = new Timer(true);
    +                   TimerTask task = new TimerTask() {
    +                           @Override
    +                           public void run() {
    +                                   // verify that we actually are 
connected to a cluster
    +                                   ImmutableList<DiscoveryNode> nodes = 
ImmutableList.copyOf(((TransportClient) client).connectedNodes());
    +                                   if (nodes.isEmpty()) {
    +                                           if (LOG.isInfoEnabled()) {
    +                                                   LOG.info("Connection 
Lost..Trying to reconnect to Elasticsearch nodes...");
    +                                           }
    +                                           open(new Configuration());
    --- End diff --
    
    I would not recommend calling the open() method from invoke(). Open() is a 
"lifecycle" method called by Flink. You should assume its only called one.
    However, you can move the (re)connect logic into a separate method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to