Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1856#discussion_r62296025
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMinFunction.java
---
@@ -72,8 +73,8 @@ public T reduce(T value1, T value2) throws Exception {
for (int position : fields) {
// Save position of compared key
// Get both values - both implement comparable
- Comparable comparable1 =
value1.getFieldNotNull(position);
- Comparable comparable2 =
value2.getFieldNotNull(position);
+ Comparable comparable1 =
((Tuple)value1).getFieldNotNull(position);
--- End diff --
@tillrohrmann
Any suggestions here? Should we handle the scala Tuple in another JIRA?
Am not an expert in Scala. Just started working with it. So if it can be
handled in another JIRA, this PR can be integrated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
