[ 
https://issues.apache.org/jira/browse/FLINK-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273989#comment-15273989
 ] 

ASF GitHub Bot commented on FLINK-3754:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1958#issuecomment-217430461
  
    I took a brief look at the PR. The overall structure of the validation 
looks good to me. Will do a more in-depth review in the next days. @twalthr, 
can you have another look as well?
    Thanks, Fabian


> Add a validation phase before construct RelNode using TableAPI
> --------------------------------------------------------------
>
>                 Key: FLINK-3754
>                 URL: https://issues.apache.org/jira/browse/FLINK-3754
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>    Affects Versions: 1.0.0
>            Reporter: Yijie Shen
>            Assignee: Yijie Shen
>
> Unlike sql string's execution, which have a separate validation phase before 
> RelNode construction, Table API lacks the counterparts and the validation is 
> scattered in many places.
> I suggest to add a single validation phase and detect problems as early as 
> possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to