[
https://issues.apache.org/jira/browse/FLINK-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276111#comment-15276111
]
ASF GitHub Bot commented on FLINK-3881:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1970#issuecomment-217807008
Thanks for your contribution @mans2singh. Changes look good. Will merge
this PR.
> Error in Java 8 Documentation Sample
> ------------------------------------
>
> Key: FLINK-3881
> URL: https://issues.apache.org/jira/browse/FLINK-3881
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 1.0.3
> Environment: All
> Reporter: Mans Singh
> Assignee: Mans Singh
> Priority: Minor
> Labels: documentation, java8, sample
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The java8 documentation
> (https://ci.apache.org/projects/flink/flink-docs-master/apis/java8.html) has
> samples, one of them included below:
> {code:java}
> DataSet<String> input = env.fromElements(1, 2, 3);
> // collector type must be declared
> input.flatMap((Integer number, Collector<String> out) -> {
> for(int i = 0; i < number; i++) {
> out.collect("a");
> }
> })
> // returns "a", "a", "aa", "a", "aa" , "aaa"
> .print();
> {code}
> I tried the sample and I think there are two issues with it (unless I have
> missed anything):
> 1. The DataSet should be DataSet<Integer> and not DataSet<String>
> 2. There should probably be a StringBuffer that, in the flatMap function, is
> used to append "a" in the for loop and output (using
> out.collect(buffer.toString()) it rather than just out.collect("a");.
> Currently, this produces only "a" each time rather than "a", "a", "aa",
> "a", "aa" , "aaa" as shown the comments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
