pnowojski commented on a change in pull request #15683:
URL: https://github.com/apache/flink/pull/15683#discussion_r624983898



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/net/ConnectionUtils.java
##########
@@ -352,7 +352,7 @@ private static boolean tryToConnect(
             return true;
         } catch (Exception ex) {
             String message =
-                    "Failed to connect from address '" + fromAddress + "': " + 
ex.getMessage();
+                    "Failed to connect from address '" + fromAddress + "' to 
address '" + toSocket + "': " + ex.getMessage();

Review comment:
       Could you deduplicate this line with 338? Extract
   ```
   String detailedMessage = "to connect  to (toSocket) from local address 
fromAddres with timeout timeout"
   ```
   (it's also a better message) and re-use `detailedMessage` both in L338 and 
L355?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to