dawidwys commented on a change in pull request #15789:
URL: https://github.com/apache/flink/pull/15789#discussion_r625661050
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1574,6 +1574,12 @@ public void run() {
// we need do continue despite that
try {
invokable.cancel();
+ // Wait for any active actions to complete (e.g. timers,
mailbox actions)
+ // Before that, interrupt to notify them know about
cancellation
+ if (invokable.shouldInterruptOnCancel()) {
+ executer.interrupt();
+ }
+ invokable.getTerminationFuture().join();
Review comment:
I see. Ok, that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
