Github user thvasilo commented on the pull request:

    https://github.com/apache/flink/pull/656#issuecomment-218399619
  
    Hello @skavulya thank you for your contribution, I'm looking forward to the 
PR!
    
    Re. the regularization penalty, we it changed to make user choice easier, 
e.g. preventing the use of an L1 penalty when L-BFGS is used.
    
    Personally I would prefer to go back to the original design and have it as 
a settable parameter, and apply some sanity checking within the optimizer to 
avoid cases like the one mentioned above.
    
    I would suggest you open the PR and we can discuss it there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to