ssoydan opened a new pull request #15835:
URL: https://github.com/apache/flink/pull/15835
## What is the purpose of the change
The old command unintentionally breaks other dependency versions if the
Flink version exactly matches the dependency version.
Versions-maven-plugin properly updates **only** the project's version.
## Brief change log
- *Use versions-maven-plugin to properly update versions*
## Verifying this change
This change is a trivial fix for the release scripts without any test
coverage.
How to run the scripts (optional OLD_VERSION -> default value = current
version):
OLD_VERSION=1.14-SNAPSHOT NEW_VERSION=1.14
./releasing/update_branch_version.sh
OLD_VERSION=1.14-SNAPSHOT NEW_VERSION=1.14
./releasing/create_release_branch.sh
How to see the change actually works:
Assuming being checked out on the current master branch, try changing
"maven-dependency-analyzer" version from 1.11.1 to 1.14-SNAPSHOT (same as the
project version) just for testing and see running the old script changes/breaks
it (which happened with our fork for 1.11.1 release as described in the issue)
whereas the new script won't touch it.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
