[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279859#comment-15279859
 ] 

ASF GitHub Bot commented on FLINK-3852:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1982#discussion_r62818792
  
    --- Diff: 
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
 ---
    @@ -32,28 +32,29 @@
      *                 mvn clean package
      * in the projects root directory.
      * You will find the jar in
    - *                 target/flink-quickstart-0.1-SNAPSHOT-Sample.jar
    - *
    + *                 target/flink-quickstart-0.1-SNAPSHOT.jar
    + * From the cli you can then run
    + *                 ./bin/flink run -c  <BatchJob> <quickstart 
jar>
      */
    -public class Job {
    +public class BatchJob {
     
        public static void main(String[] args) throws Exception {
    -           // set up the execution environment
    +           // set up the batch execution environment
                final ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
     
    -
                /**
                 * Here, you can start creating your execution plan for Flink.
                 *
                 * Start with getting some data from the environment, like
    -            *      env.readTextFile(textPath);
    +            * env.readTextFile(textPath);
    --- End diff --
    
    I think this space was intended formatting, like the below .filter(), 
.flatMap() etc.


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---------------------------------------------------------------
>
>                 Key: FLINK-3852
>                 URL: https://issues.apache.org/jira/browse/FLINK-3852
>             Project: Flink
>          Issue Type: Task
>          Components: Quickstarts
>            Reporter: Robert Metzger
>              Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to