zentol commented on pull request #15827: URL: https://github.com/apache/flink/pull/15827#issuecomment-832728951
Well this was quite an ordeal. The quickstart test failure was related; archetype jars contain an archetype-metadata.xml file under `META-INF/maven`, that was now accidentally removed. The filter pattern was adjusted to ignore this files. We then had various files still containing poms under `META-INF/maven`. Once cause was jars being built with the `maven-(jar|assembly|source)-plugin`, which needed to be configured separately to not add these files. The second cause was various modules using ever so slightly shade-plugin setups; some were flat-out overriding the configuration of the parent so they didn't inherit things (like cassandra), others like flink-dist have special shade-plugin executions for _reasons_. This was resolved by moving the filters (and common transformers, while I was at it) into the general configuration of the shade-plugin (i.e., independent of any execution) and making small adjustments here and there as to how configurations are inherited/merged. Finally, the java11 exclusive dependencies still contained poms, because the pattern assumed this directory to always be present under `META-INF/maven`, but for multi-release jars it can be present under `META-INF/versions/...`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
